kotlin: add cancel stream test and fix custom yaml path #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buildbreaker
changed the title
buildbreaker
changed the title
library/java/io/envoyproxy/envoymobile/engine/EnvoyEngineImpl.java
Outdated
Show resolved
Hide resolved
junr03
reviewed
Apr 29, 2021
library/java/io/envoyproxy/envoymobile/engine/EnvoyEngineImpl.java
Outdated
Show resolved
Hide resolved
junr03
previously approved these changes
May 4, 2021
There was a problem hiding this comment.
lgtm, pending issue for missing method, and main merge. Thanks @buildbreaker! More tests, more better :)
added 9 commits
May 4, 2021 15:02
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
buildbreaker
force-pushed
the
kotlin-add-cancel-stream-test
branch
from
e24eb69
to
3c51111
Compare
added 2 commits
May 4, 2021 15:12
Signed-off-by: Alan Chiu <[email protected]>
Signed-off-by: Alan Chiu <[email protected]>
goaway
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a cancel stream test to mirror swift's cancel stream test: https://github.com/envoyproxy/envoy-mobile/blob/102b40d0da174200b4308a2677f6788a1df2a0aa/test/swift/integration/CancelStreamTest.swift
Found that the custom yaml configuration also has a bug in it where it does not appropriately register platform and native filters when a custom yaml is used. Luckily this is the first usage of the custom yaml. The JNI structure is different from the objective-c structure but I think I was able to mimic it as close as possible by just requiring an
EnvoyConfiguration.The API changes are here: https://github.com/envoyproxy/envoy-mobile/pull/1424/files#diff-c4d0f50e81c31efc078d029708e09a001ea3e466c6b38141c027fad21c6b70abR30-R34
Signed-off-by: Alan Chiu [email protected]
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: kotlin: add cancel stream test and fix custom yaml path
Risk Level: low
Testing: integration test
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]